Fix performance of DPF vector #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
+ Coverage 83.75% 83.82% +0.07%
==========================================
Files 90 90
Lines 10388 10396 +8
==========================================
+ Hits 8700 8714 +14
+ Misses 1688 1682 -6 |
…ix/perf_issue_dpf_vector
…s/pydpf-core into fix/perf_issue_dpf_vector
PProfizi
reviewed
May 5, 2025
|
|
||
| # The updated version of the DPF vector will always be committed to DPF. | ||
| # Ideally, this should be set to True only when modified, however this is not possible to do that efficiently. | ||
| # Consequently, for performance reasons, it's much better to always commit the vector to DPF rather than |
There was a problem hiding this comment.
@cbellot000 is this also true in the case of a huge vector in gRPC on a remote machine with a high ping?
There was a problem hiding this comment.
My point is that performance improvements reported are for gRPC communications with a local server, is that right?
There was a problem hiding this comment.
since it's twice faster, I think that it should be safe to assume that it will as fast
rafacanton
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #2201
DPF vector became slow because they were always checking if the modification of the vector by
Why performance changed between 0.13.6 and master?
Before 0.13.7.dev, it was hard coded that in process dpf vector wouldn't "check modification" and though bypassed dpf server logic. 0.13.7.dev is now relying on DPF server logic for updating or not dpf vector.
Proposed fixes
Benchmark
Test is taken for #2201, changing params are: